Refactor binary operator binding in preparation for future work. #78832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the process a small bug was fixed. Binding of instance compound assignment operators was made consistent with binding against static binary operators with respect to `implicit object creation` and `default` operands.
AlekseyTs
added
Area-Compilers
Feature - Extension Everything
AlekseyTs
commented
Jun 5, 2025
| @@ -114,11 +114,26 @@ private BoundExpression BindCompoundAssignment(AssignmentExpressionSyntax node, | |||
| leftPlaceholder: null, leftConversion: null, finalPlaceholder: null, finalConversion: null, LookupResultKind.NotAVariable, CreateErrorType(), hasErrors: true); | |||
| } | |||
|
|
|||
| if (!IsTypelessExpressionAllowedInBinaryOperator(kind, left, right)) | |||
AlekseyTs
commented
Jun 5, 2025
| return createBadCompoundAssignmentOperator(node, kind, left, right, resultKind, originalUserDefinedOperators, diagnostics); | ||
| } | ||
|
|
||
| if (best.Signature.Method is { } bestMethod) |
AlekseyTs
commented
Jun 5, 2025
| @@ -847,7 +929,17 @@ private bool BindSimpleBinaryOperatorParts(BinaryExpressionSyntax node, BindingD | |||
| out BinaryOperatorSignature resultSignature, out BinaryOperatorAnalysisResult best) | |||
| { | |||
| bool foundOperator; | |||
| best = this.BinaryOperatorOverloadResolution(kind, isChecked: CheckOverflowAtRuntime, left, right, allowExtensions: true, node, diagnostics, out resultKind, out originalUserDefinedOperators); | |||
|
|
|||
| if (!IsTypelessExpressionAllowedInBinaryOperator(kind, left, right)) | |||
AlekseyTs
commented
Jun 5, 2025
| @@ -865,6 +957,12 @@ private bool BindSimpleBinaryOperatorParts(BinaryExpressionSyntax node, BindingD | |||
| { | |||
| var signature = best.Signature; | |||
|
|
|||
| if (signature.Method is { } bestMethod) | |||
AlekseyTs
commented
Jun 5, 2025
| var best = this.BinaryOperatorOverloadResolution(kind, isChecked: CheckOverflowAtRuntime, left, right, allowExtensions: true, node, diagnostics, out lookupResult, out originalUserDefinedOperators); | ||
| BinaryOperatorAnalysisResult best; | ||
|
|
||
| if (!IsTypelessExpressionAllowedInBinaryOperator(kind, left, right)) |
AlekseyTs
commented
Jun 5, 2025
| @@ -1134,6 +1243,12 @@ private BoundExpression BindConditionalLogicalOperator(BinaryExpressionSyntax no | |||
| // bool, or we've got a valid user-defined operator. | |||
| BinaryOperatorSignature signature = best.Signature; | |||
|
|
|||
| if (signature.Method is { } bestMethod) | |||
AlekseyTs
commented
Jun 5, 2025
| return possiblyBest; | ||
|
|
||
| BinaryOperatorAnalysisResult nonExtensionOverloadResolution( |
AlekseyTs
commented
Jun 5, 2025
| return possiblyBest; | ||
| } | ||
|
|
||
| static BinaryOperatorAnalysisResult analyzeOverloadResolutionResult(BinaryOperatorOverloadResolutionResult result, out LookupResultKind resultKind, out ImmutableArray<MethodSymbol> originalUserDefinedOperators) |
|
@jcouv, @dotnet/roslyn-compiler Please review. |
|
@jcouv, @dotnet/roslyn-compiler Please review. |
RikkiGibson
approved these changes
Jun 6, 2025
| bool checkOverflowAtRuntime, | ||
| BoundExpression left, | ||
| BoundExpression right, | ||
| ref AnalyzedArguments? analyzedArguments, |
There was a problem hiding this comment.
It might be reasonable to make this an out AnalyzedArguments analyzedArguments, since it doesn't look like the value coming in is used, and then the assertion at the call site could be removed. #Resolved
There was a problem hiding this comment.
It might be reasonable to make this an
out AnalyzedArguments analyzedArguments, since it doesn't look like the value coming in is used, and then the assertion at the call site could be removed.
In the next PR it will be used as a "true" ref parameter.
|
@jcouv, @dotnet/roslyn-compiler For the second review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process a small bug was fixed. Binding of instance compound assignment operators was made consistent with binding against static binary operators with respect to
implicit object creationanddefaultoperands.