Add a layer of constraint filtering for 'add import for extension methods' completion. #78923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@dibarbet ptal. |
JoeRobich
approved these changes
Jun 11, 2025
This was referenced Jun 18, 2025
This was referenced Jun 26, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler is often too permissive here. Specifically when an extension is on a naked type parameter. This means that lots of extensions of the form
E<T>(T t) where T : IComplexConstraintend up showing up where they shouldn't (pretty much on all objects).This adds a poor man's filtering step where we try to filter out obvious cases where the receiver type in question could never satisfy those constraints.