Fix locating startup objects #78972
Merged
Fix locating startup objects #78972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This existed back from when the input to the function was a namespace, but that's not the case anymore.
CPS passes us an INamespaceSymbol that is the global namespace symbol; it doesn't have a containing assembly. It does have a containing Compilation though, which is what we actually need. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2506795 Fixes dotnet#78697
I'm not sure why this ever took an INamespaceSymbol in the first place, but we either have code working around it, or having an (old) comment saying the code was wrong.
CyrusNajmabadi
approved these changes
Jun 14, 2025
jasonmalinowski
commented
Jun 14, 2025
| /// </summary> | ||
| /// <param name="compilation">The compilation to search.</param> | ||
| /// <param name="findFormsOnly">Restrict the search to only Windows Forms classes. Note that this is only implemented for VisualBasic</param> | ||
| IEnumerable<INamedTypeSymbol> FindEntryPoints(Compilation compilation, bool findFormsOnly); |
There was a problem hiding this comment.
FYI @drewnoakes here's an improved method for you to call here:
https://github.com/dotnet/project-system/blob/05aa25172c582d92041fdac9b15ee826e28ec1ef/src/Microsoft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Properties/StartupObjectsEnumProvider.cs#L87
https://github.com/dotnet/project-system/blob/05aa25172c582d92041fdac9b15ee826e28ec1ef/src/Microsoft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Properties/VisualBasic/SplashScreenEnumProvider.cs#L86
The .GlobalNamespace line isn't right, so we've been working around it all these years. A cleanup on our side to deal with this then broke stuff.
There was a problem hiding this comment.
Thanks! Filed dotnet/project-system#9676
jasonmalinowski
added a commit
that referenced
this pull request
Jun 20, 2025
CPS passes us an INamespaceSymbol that is the global namespace symbol; it doesn't have a containing assembly. It does have a containing Compilation though, which is what we actually need. This is a 17.14 backport of the specific fix from #78972 but removes the other cleanup and the introduction of a new API that won't ever be consumed in 17.14. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2506795 Fixes #78697
This was referenced Jun 20, 2025
This was referenced Jun 26, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPS passes us an INamespaceSymbol that is the global namespace symbol; it doesn't have a containing assembly. It does have a containing Compilation though, which is what we actually need.
While I'm here, let's expose a better API for this to avoid this silly dance in the first place.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2506795
Fixes #78697