Inline Method Refactoring - Fix bug for field with multiple declarations #78988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
reviewed
Jun 16, 2025
src/Features/Core/Portable/InlineMethod/AbstractInlineMethodRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest/CodeActions/InlineMethod/CSharpInlineMethodTests.cs
Outdated
Show resolved
Hide resolved
| { | ||
| return fieldSymbol; | ||
| foreach (var declarator in node.DescendantNodes().OfType<SyntaxNode>() | ||
| .Where(n => _syntaxFacts.IsVariableDeclarator(n))) |
There was a problem hiding this comment.
so this is a case where you want the descendent nodes to not descend in once you've hit an IsVariableDeclarator node.
Imagine you have something like Action f = () => { var v = methodInvocation(); }. You'll hit both the f = ... declarator and the v = ... declarator.
Technically, not the end of the world here as you validate you're getting an IFieldSymbol. But it's subtle and potentially a problem in the future. so better is to not descend any further once you hit the first layer of variable declarators.
does that make sense?
CyrusNajmabadi
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76656