Skip to content

Fix a couple of issues with committing and diagnostic reporting #79018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2025
Merged

Fix a couple of issues with committing and diagnostic reporting #79018

merged 3 commits into from
Jun 18, 2025

Conversation

tmat
Copy link
Member

@tmat tmat commented Jun 17, 2025 •
edited
Loading

  1. Solution update shouldn't be committed when rude edits are reported.
  2. Diagnostics were incorrectly reported to dotnet watch

Improve tests.

@tmat tmat requested a review from a team as a code owner June 17, 2025 20:19
@tmat
Copy link
Member Author

tmat commented Jun 17, 2025

@DustinCampbell Simple fixes. PTAL

@tmat tmat enabled auto-merge (squash) June 18, 2025 14:52
@tmat tmat merged commit 072625c into dotnet:main Jun 18, 2025
24 of 25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jun 18, 2025
This was referenced Jun 21, 2025
Closed
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Jun 29, 2025
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DustinCampbell DustinCampbell DustinCampbell approved these changes

Assignees
No one assigned
Labels
Area-Interactive VSCode
Projects
None yet
Milestone
18.0 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @DustinCampbell @RikkiGibson