Fix issue where we offered to use a collection expression when teh user didn't have a viable Add method #79157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er didn't have a viable Add method
CyrusNajmabadi
commented
Jun 26, 2025
| // can take those constructor arguments and pass them along to the final collection by spreading them. | ||
| // If not, then we can't convert this to a collection expression. | ||
| var addMethods = this.GetAddMethods(cancellationToken); | ||
| if (!addMethods.Any(m => m.Parameters is [{ Type: var parameterType }] && Equals(parameterType, elementType))) | ||
| return false; |
There was a problem hiding this comment.
heuristic was too weak. have tightened it up.
akhera99
approved these changes
Jun 26, 2025
AbhitejJohn
approved these changes
Jun 26, 2025
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79156