Tweak clarity rules for parentheses where ?? is involved #79159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhera99
approved these changes
Jun 26, 2025
| { | ||
| void M() | ||
| { | ||
| int x = (a + b) ?? c; |
There was a problem hiding this comment.
where in the code does it decide to parenthesize like this rather than a + (b ?? c)
CyrusNajmabadi
commented
Jun 26, 2025
| // only add parentheses within the same precedence band. | ||
| if (childEquivalenceKey != parentEquivalenceKey) | ||
| { | ||
| if (IsClearPrecedenceBoundary()) |
There was a problem hiding this comment.
@akhera99 here. we view the precedence as unclear. the fixer then actually wraps with parens (that fixer didn't need to change, it just trusts what the analyzer reports).
akoeplinger
added a commit
to dkurepa/dotnet
that referenced
this pull request
Jul 8, 2025
Likely caused by dotnet/roslyn#79159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78841