Improve performance in metadata-to-project-reference conversion #79163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of small improvements: - Make CanConvertMetadataReferenceToProjectReference take ProjectStates rather than the IDs and doing the lookups. The ID -> State lookup is O(log n), but doing that a lot on a high traffic method like that was showing up in traces. - Rather than looping through IDs and then grabbing states in ConvertMetadataReferencesToProjectReference, we can just loop across states directly. - Avoid calling CanConvertMetadataReferenceToProjectReference if there's no references, which is common during load where we might know all the output paths up front but not the references which come in later. - Use DoesProjectTransitivelyDependOnProject when checking for P2P references, which takes advantage of the map in either direction.
src/Workspaces/Core/Portable/Workspace/ProjectSystem/ProjectSystemProjectFactory.cs
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Workspace/ProjectSystem/ProjectSystemProjectFactory.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Jun 27, 2025
jasonmalinowski
deleted the
perf-optimizations-for-project-reference-conversion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of small improvements: