Speed up performance of remove-unused-imports fix all #79173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Jun 27, 2025
| using Microsoft.CodeAnalysis.Formatting; | ||
| using Microsoft.CodeAnalysis.Shared.Extensions; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.RemoveUnnecessaryImports; | ||
|
|
||
| internal abstract class AbstractRemoveUnnecessaryImportsCodeFixProvider : CodeFixProvider | ||
| internal abstract class AbstractRemoveUnnecessaryImportsCodeFixProvider : SyntaxEditorBasedCodeFixProvider |
There was a problem hiding this comment.
this allows the fixer to work on individual documents in parallel. It doesn't need to run them serially.
CyrusNajmabadi
commented
Jun 27, 2025
| // We don't need to perform any cleanup for this code fix. It simply removes code, leaving | ||
| // things in the state it already needs to be in. | ||
| protected override CodeActionCleanup Cleanup => CodeActionCleanup.None; | ||
| #endif |
There was a problem hiding this comment.
this ensures that after the fixer runs, the Code Action system itself doesn't do an full semantic pass on the resultant documents to clean them up.
AbhitejJohn
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.