Add more telemetry during copilot change adjustment #79216
Merged
+30
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Jul 1, 2025
|
|
||
| // Record how many new edits were made to the proposal. Expectation is that this is commonly only 1, | ||
| // but we want to see how that potentially changes over time, especially as we add more adjusters. | ||
| d["AdjustmentsCount"] = newProposal.Edits.Count - proposal.Edits.Count; |
There was a problem hiding this comment.
this is new. The above stuff is just cleanup.
CyrusNajmabadi
commented
Jul 1, 2025
| /// applied to the original edits. The <see cref="Proposal"/> system may reject them based on their own criteria. | ||
| /// </summary> | ||
| private async Task<ProposalBase?> AdjustProposalAsync( | ||
| Solution solution, ProposalBase proposal, CancellationToken cancellationToken) |
There was a problem hiding this comment.
this is just cleanup. i prefered just returning a result and having the boolean values computed at the callsite.
AbhitejJohn
approved these changes
Jul 1, 2025
3 tasks
CyrusNajmabadi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.