Skip to content

Razor: Don't double register for document sync #79241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

Razor: Don't double register for document sync #79241

merged 2 commits into from
Jul 3, 2025

Conversation

davidwengier
Copy link
Member

@davidwengier davidwengier requested a review from a team July 3, 2025 03:53
@davidwengier davidwengier requested a review from a team as a code owner July 3, 2025 03:53
alexgav
alexgav approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@alexgav alexgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

JoeRobich
JoeRobich approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the test lsp host doesn't have the workspace/configuration endpoint registered.

@build-analysis build-analysis bot mentioned this pull request Jul 3, 2025
Open
3 tasks
@davidwengier davidwengier merged commit 17f8201 into dotnet:main Jul 3, 2025
25 checks passed
@davidwengier davidwengier deleted the FixCohostingInDevKit branch July 3, 2025 07:45
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 3, 2025
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

+1 more reviewer

@alexgav alexgav alexgav approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Area-IDE VSCode
Projects
None yet
Milestone
18.0 P1
Development

Successfully merging this pull request may close these issues.

[VS Code] [Cohosting] Ensure cohosting works with DevKit
4 participants
@davidwengier @JoeRobich @alexgav @RikkiGibson