Skip to content

Conversation

davidwengier
Copy link
Member

@davidwengier davidwengier commented Jul 4, 2025

Part of dotnet/razor#12009
Razor side: dotnet/razor#12015

Razor currently has a DevKit DLL to support telemetry in rzls.exe, but for the assembly that runs in the language server as an extension, we had nothing. This allows us to report through the Roslyn reporter, which does the same DevKit stuff.

Also creates a new initializer service we can provide, because previously we were abusing the dynamic file info system to get the workspace, and one day (with a bit of luck) that whole system will go away, so it's nice to remove a lynchpin.

Copy link
Contributor

@alexgav alexgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwengier davidwengier merged commit 10a34cc into dotnet:main Jul 7, 2025
26 checks passed
@davidwengier davidwengier deleted the RazorExtensionTelemetry branch July 7, 2025 21:53
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 7, 2025
davidwengier added a commit to dotnet/razor that referenced this pull request Jul 9, 2025
)

Fixes #12009

Needs a Roslyn bump before this will compile. Roslyn PR:
dotnet/roslyn#79254
@lonix1
Copy link

lonix1 commented Aug 7, 2025

Was just offered the 2.87.31 update, read the changelog, and found these PRs related to telemetry: #79254, dotnet/razor#12015, dotnet/razor#12001. How can we disable such telemetry?

@davidwengier
Copy link
Member Author

I've no idea, but hopefully @dibarbet or maybe @timheuer knows?

I should note, the changes in Razor are not introducing telemetry to the system, just reporting the existing telemetry through the Roslyn reporter instead of the Razor reporter for architectural reasons. If you've previously disabled telemetry reporting then that would still be in effect. Also, telemetry is only reported if you have the Dev Kit extension, with just the basic C# extension there is no telemetry.

@JoeRobich
Copy link
Member

VSCode telemetry can be controlled by configuring telemetry.telemetryLevel in settings. See https://code.visualstudio.com/docs/configure/telemetry#_disable-telemetry-reporting

@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants