Initial support for adding obsolete attributes to primary constructors #79271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Jul 7, 2025
| @@ -25,7 +26,7 @@ namespace Microsoft.CodeAnalysis.Analyzers.MetaAnalyzers.Fixers | |||
| [method: Obsolete("This exported object must be obtained through the MEF export provider.", error: true)] | |||
| public sealed class FixerWithFixAllFix() : CodeFixProvider | |||
| { | |||
| public sealed override ImmutableArray<string> FixableDiagnosticIds { get; } = ImmutableArray.Create(DiagnosticIds.OverrideGetFixAllProviderRuleId); | |||
| public sealed override ImmutableArray<string> FixableDiagnosticIds { get; } = [DiagnosticIds.OverrideGetFixAllProviderRuleId]; | |||
There was a problem hiding this comment.
just cleanup in this file.
CyrusNajmabadi
commented
Jul 7, 2025
|
|
||
| namespace Microsoft.CodeAnalysis.Analyzers.MetaAnalyzers.Fixers | ||
| { | ||
| public abstract class ApplyDiagnosticAnalyzerAttributeFix : CodeFixProvider | ||
| { | ||
| public sealed override ImmutableArray<string> FixableDiagnosticIds { get; } = ImmutableArray.Create(DiagnosticIds.MissingDiagnosticAnalyzerAttributeRuleId); | ||
| public sealed override ImmutableArray<string> FixableDiagnosticIds { get; } = [DiagnosticIds.MissingDiagnosticAnalyzerAttributeRuleId]; |
There was a problem hiding this comment.
just cleanup in this file.
CyrusNajmabadi
commented
Jul 7, 2025
| using Microsoft.CodeAnalysis.Text; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.Analyzers.MetaAnalyzers.Fixers | ||
| { | ||
| public abstract class CompareSymbolsCorrectlyFix : CodeFixProvider | ||
| { | ||
| public sealed override ImmutableArray<string> FixableDiagnosticIds { get; } = | ||
| ImmutableArray.Create(DiagnosticIds.CompareSymbolsCorrectlyRuleId); | ||
| [DiagnosticIds.CompareSymbolsCorrectlyRuleId]; |
There was a problem hiding this comment.
just cleanup in this file.
CyrusNajmabadi
commented
Jul 7, 2025
| using Microsoft.CodeAnalysis.Text; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.Analyzers.MetaAnalyzers.Fixers | ||
| { | ||
| public abstract class ConfigureGeneratedCodeAnalysisFix : CodeFixProvider | ||
| { | ||
| public override ImmutableArray<string> FixableDiagnosticIds { get; } = ImmutableArray.Create(ConfigureGeneratedCodeAnalysisAnalyzer.Rule.Id); | ||
| public override ImmutableArray<string> FixableDiagnosticIds { get; } = [ConfigureGeneratedCodeAnalysisAnalyzer.Rule.Id]; |
There was a problem hiding this comment.
just cleanup in this file.
CyrusNajmabadi
commented
Jul 7, 2025
| DiagnosticIds.DefineDiagnosticTitleCorrectlyRuleId, | ||
| DiagnosticIds.DefineDiagnosticMessageCorrectlyRuleId, | ||
| DiagnosticIds.DefineDiagnosticDescriptionCorrectlyRuleId, | ||
| ]; |
There was a problem hiding this comment.
just cleanup in this file.
CyrusNajmabadi
commented
Jul 7, 2025
| using Microsoft.CodeAnalysis.Text; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.Analyzers.MetaAnalyzers.Fixers | ||
| { | ||
| public abstract class EnableConcurrentExecutionFix : CodeFixProvider | ||
| { | ||
| public override ImmutableArray<string> FixableDiagnosticIds { get; } = ImmutableArray.Create(EnableConcurrentExecutionAnalyzer.Rule.Id); | ||
| public override ImmutableArray<string> FixableDiagnosticIds { get; } = [EnableConcurrentExecutionAnalyzer.Rule.Id]; |
There was a problem hiding this comment.
just cleanup in this file.
CyrusNajmabadi
commented
Jul 7, 2025
| using Microsoft.CodeAnalysis; | ||
| using Microsoft.CodeAnalysis.CodeActions; | ||
| using Microsoft.CodeAnalysis.CodeFixes; | ||
| using Microsoft.CodeAnalysis.CSharp.Syntax; | ||
| using Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers; | ||
| using Microsoft.CodeAnalysis.Shared.Extensions; |
There was a problem hiding this comment.
moving off of duplicative extension to roslyn ones.
CyrusNajmabadi
commented
Jul 7, 2025
| GenerateErrorArgument(generator, allowNamedArgument: document.Project.Language == LanguageNames.CSharp), | ||
| ]); | ||
|
|
||
| obsoleteAttributeList = isPrimaryConstructorTypeDeclaration ? this.AddMethodTarget(obsoleteAttributeList) : obsoleteAttributeList; |
There was a problem hiding this comment.
this is the updated logic.
CyrusNajmabadi
commented
Jul 7, 2025
| { | ||
| var source = $@" |
There was a problem hiding this comment.
switched to raw strings and file scoped namespace.
CyrusNajmabadi
commented
Jul 7, 2025
| [WindowsOnlyTheory] | ||
| [InlineData("System.Composition")] | ||
| [InlineData("System.ComponentModel.Composition")] | ||
| public async Task NotMarkedObsolete_PrimaryConstructor_CSharpAsync(string mefNamespace) |
There was a problem hiding this comment.
new test for thsi scenario.
| @@ -1,45 +0,0 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
There was a problem hiding this comment.
duplicates of roslyn extensions. deleted.
|
@JoeRobich ptal. |
JoeRobich
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been annoying me that this Roslyn-Analyzers fixer doesn't work the moment you use primary constructors.