Adds EqualityComparer<T>.Create polyfill #79345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/roslyn-compiler @dotnet/roslyn-ide ptal |
jjonescz
approved these changes
Jul 15, 2025
AlekseyTs
reviewed
Jul 15, 2025
AlekseyTs
reviewed
Jul 15, 2025
AlekseyTs
reviewed
Jul 15, 2025
src/Compilers/Core/CodeAnalysisTest/InternalUtilities/OneOrManyTests.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jul 15, 2025
src/Compilers/CSharp/Test/Semantic/SourceGeneration/GeneratorDriverTests.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jul 15, 2025
src/Compilers/CSharp/Test/Semantic/SourceGeneration/StateTableTests.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jul 15, 2025
src/Compilers/CSharp/Test/Semantic/SourceGeneration/StateTableTests.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jul 15, 2025
src/Compilers/CSharp/Test/Semantic/SourceGeneration/SyntaxAwareGeneratorTests.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jul 15, 2025
src/Compilers/CSharp/Test/Semantic/SourceGeneration/SyntaxAwareGeneratorTests.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jul 15, 2025
src/Compilers/CSharp/Test/Semantic/SourceGeneration/SyntaxAwareGeneratorTests.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jul 15, 2025
src/Compilers/CSharp/Test/Semantic/SourceGeneration/SyntaxAwareGeneratorTests.cs
Outdated
Show resolved
Hide resolved
|
Done with review pass (commit 5). I suggest reverting all changes under Compilers. #Closed |
Why? All tests are passing. The difference in behavior is insignificant for behaviors being tested. |
None of the changes are necessary and I do not find them useful enough to worry about the impact and review the changes. The only change I would take is the removal of a comparer type that was not used even before the change. #Closed |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
333fred
approved these changes
Jul 17, 2025
tmat
force-pushed
the
EqualityComparerPolyfils
branch
from
132e0d6 to
c2e6539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move ReferenceEqualityComparer polyfill to MS.CA.Contracts.