Fix 'use var' with spans #79348
Merged
Fix 'use var' with spans #79348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Jul 12, 2025
| { | ||
| var containsStackAlloc = initializer | ||
| .DescendantNodesAndSelf(descendIntoChildren: node => node is not AnonymousFunctionExpressionSyntax) | ||
| .Any(node => node.IsKind(SyntaxKind.StackAllocArrayCreationExpression)); |
There was a problem hiding this comment.
this was a case where we were too aggressive in bailing out. We really only need to bail out for exactly one form. The rest are fine. In other words, only Span<X> x = stackalloc X[...]; cannot be converted to var. any other use of stackalloc on the rhs (including just wrapping it in parens) is fine, as the compiler/lang always treats that as Span<>
|
@JoeRobich ptal. |
3 tasks
AbhitejJohn
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79337