Razor span mapping in LSP for cohosting #79677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
approved these changes
Jul 30, 2025
This was referenced Aug 1, 2025
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
Aug 6, 2025
Fixes #12054 Part of #9519 Needs ~dotnet/roslyn#79604 and~ dotnet/roslyn#79677 to insert before this will build This PR implements the workspace version of our span mapping service, since the old one is hooked up via a document service, which we can't do in cohosting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #79604
Part of dotnet/razor#9519
This is the follow up to the above PR to support rename in LSP, but thought I'd make the API slightly stronger while I was here since we haven't consumed it on Razor yet. I also misunderstood the span mapping API, and it needing to return an array of the same length as the input.