Update debugger packages, move to PortableInterop IMetadataImport #80063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
Community
gregg-miskelly
approved these changes
Aug 28, 2025
JoeRobich
reviewed
Aug 28, 2025
tmat
approved these changes
Aug 28, 2025
dibarbet
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in microsoft/ConcordExtensibilitySamples#124, the debugger will be breaking the public definition of
IMetadataImport. This change updates the debugger package versions to latest versions in order to pick up the new definition under theMicrosoft.MetadataReader.PortableInteropnamespace and migrates the Roslyn usage off of the debugger definition inMicrosoft.MetadataReader.IMetadataImport. This also updates theDkmMetadataImportHoldermock to expose the same property as the real class, `Notably the new definition no longer uses
StringBuildermarshalling, which should nominally improve performance.