More MS.CA.CSharp resource cleanup #80100
Open
+0
−1,496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
Community
Youssef1313
force-pushed
the
more-resources-cleanup
branch
from
41df0c8 to
47ae2db
Compare
AlekseyTs
reviewed
Sep 1, 2025
| @@ -3920,9 +3917,6 @@ You should consider suppressing the warning only if you're sure that you don't w | |||
| <data name="ERR_NamedArgumentForArray" xml:space="preserve"> | |||
| <value>An array access may not have a named argument specifier</value> | |||
| </data> | |||
| <data name="ERR_NotYetImplementedInRoslyn" xml:space="preserve"> | |||
There was a problem hiding this comment.
It's not present in the enum, why to keep the unused resource around?
There was a problem hiding this comment.
It's not present in the enum, why to keep the unused resource around?
If it is not present in the enum, then removing is fine
AlekseyTs
reviewed
Sep 1, 2025
| @@ -7384,9 +7321,6 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ | |||
| <data name="IDS_FeatureUtf8StringLiterals" xml:space="preserve"> | |||
| <value>UTF-8 string literals</value> | |||
| </data> | |||
| <data name="ERR_ExpressionTreeContainsUtf8StringLiterals" xml:space="preserve"> | |||
There was a problem hiding this comment.
I can't see any mentions of it in the enum (not even commented out line)
|
See #80097 (comment) as well. |
jjonescz
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.