Extensions: allow more CREFs #80114
Merged
Extensions: allow more CREFs #80114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
added
Area-Compilers
Feature - Extension Everything
3 tasks
jcouv
force-pushed
the
extensions-cref
branch
from
2595751 to
8ec786e
Compare
jjonescz
approved these changes
Sep 4, 2025
| foreach (var nested in container.GetTypeMembers()) | ||
| IEnumerable<NamedTypeSymbol> candidateTypes = containerOpt switch | ||
| { | ||
| null => enumerateCandidateTypes(containerOpt, syntax, diagnostics), |
There was a problem hiding this comment.
Why do we pass containerOpt when we know at this point that it's always null? #Resolved
AlekseyTs
reviewed
Sep 5, 2025
| { | ||
| CompoundUseSiteInfo<AssemblySymbol> useSiteInfo = GetNewCompoundUseSiteInfo(diagnostics); | ||
| LookupResult result = LookupResult.GetInstance(); | ||
| this.LookupSymbolsOrMembersInternal( |
AlekseyTs
reviewed
Sep 5, 2025
| LookupResult result = LookupResult.GetInstance(); | ||
| this.LookupSymbolsOrMembersInternal( | ||
| result, | ||
| container, |
AlekseyTs
reviewed
Sep 5, 2025
| foreach (var nested in container.GetTypeMembers()) | ||
| IEnumerable<NamedTypeSymbol> candidateTypes = containerOpt switch | ||
| { | ||
| null => enumerateCandidateTypes(containerOpt, syntax, diagnostics), |
AlekseyTs
reviewed
Sep 5, 2025
| @@ -63,6 +63,7 @@ private MultiDictionary<string, TypeParameterSymbol> CreateTypeParameterMap() | |||
| case SyntaxKind.IndexerMemberCref: | |||
| case SyntaxKind.OperatorMemberCref: | |||
| case SyntaxKind.ConversionOperatorMemberCref: | |||
| case SyntaxKind.ExtensionMemberCref: | |||
There was a problem hiding this comment.
Is this change related to "Addresses part of #78967 ("We want unqualified CREF to work within the context of enclosing static type cref="extension(int).M"")"? If not, consider adjusting PR description accordingly. #Closed
AlekseyTs
reviewed
Sep 5, 2025
| @@ -63,6 +63,7 @@ private MultiDictionary<string, TypeParameterSymbol> CreateTypeParameterMap() | |||
| case SyntaxKind.IndexerMemberCref: | |||
| case SyntaxKind.OperatorMemberCref: | |||
| case SyntaxKind.ConversionOperatorMemberCref: | |||
| case SyntaxKind.ExtensionMemberCref: | |||
|
Done with review pass (commit 1) #Closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #78967 ("We want unqualified CREF to work within the context of enclosing static type cref=
"extension(int).M"")Relates to test plan #76130