Remove code only called by tests #80140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Sep 4, 2025
| @@ -1,493 +0,0 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
There was a problem hiding this comment.
This entire complex type was never used in product scenarios. But was only called from tests... yikes.
CyrusNajmabadi
commented
Sep 4, 2025
|
|
||
| // In this case, the analyzers are ran twice. This appears to be a bug in SkippedHostAnalyzersInfo.Create, because it calls | ||
| // HostDiagnosticAnalyzers.CreateProjectDiagnosticAnalyzersPerReference which already filters out references, it doesn't return any | ||
| // references to skip. |
There was a problem hiding this comment.
yaay... a test that was only validating broken behavior from a component not actually called from real product code...
CyrusNajmabadi
force-pushed
the
removeCodeOnlyCalledByTests
branch
from
d9f15e9 to
aff20ed
Compare
JoeRobich
approved these changes
Sep 4, 2025
Comment on lines
+640
to
+641
| Assert.Equal(1, diagnosticsMapResults.Length); | ||
| var diagnostic = diagnosticsMapResults.Single(); |
There was a problem hiding this comment.
Suggested change
| Assert.Equal(1, diagnosticsMapResults.Length); | |
| var diagnostic = diagnosticsMapResults.Single(); | |
| var diagnostic = Assert.Single(diagnosticsMapResults); |
There was a problem hiding this comment.
will roll into followup. thanks!
| var analyzerResults = diagnosticsMapResults.Diagnostics.Single(); | ||
| Assert.Equal(analyzerHostId, analyzerResults.Item1); | ||
| Assert.Equal(1, analyzerResults.Item2.Semantic.Length); | ||
| var analyzerResults = diagnosticsMapResults.Single(); |
There was a problem hiding this comment.
Suggested change
| var analyzerResults = diagnosticsMapResults.Single(); |
| // references to skip. | ||
| Assert.Equal(2, diagnosticsMapResults.Diagnostics.Length); | ||
| // We should only get one diagnostic as the two analyzers have the same ID and will be deduped. | ||
| Assert.Equal(1, diagnosticsMapResults.Length); |
There was a problem hiding this comment.
Suggested change
| Assert.Equal(1, diagnosticsMapResults.Length); | |
| Assert.Single(diagnosticsMapResults); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.