ILLink.Descriptors.LibraryBuild.xml getting automatically created in non-SDK style CSPROJs

[KeanuTang]

Through a chain of updated package references, I'm noticing that this file (ILLink.Descriptors.LibraryBuild.xml) gets automatically created for C# projects that don't use an SDK style format. This impacts a lot of our older code. I've traced the source of these files to System.Diagnostics.DiagnosticSource.

I don't think this causes any harm, but it adds clutter and confusing (developers asking where it came from).

I'm not very familiar with code trimming, but does this file actually need to be included in the output of System.Diagnostics.DiagnosticSource? My specific question is, could this be changed from CONTENT to NONE?

runtime/src/libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj

Line 28 in 05d94d9

<Content Include="ILLink\ILLink.Descriptors.LibraryBuild.xml" />

Again, I'm not familiar with the intricacies of code trimming. So if it's required, then I assume "it is what it is" until we can update all our old code. But it would be nice if we didn't get these files auto created.

[jkotas]

Introduced by https://github.com/dotnet/runtime/pull/106014/files#diff-a0464194bba5f744ee1076d661cdbbddde0d1b28e28bb9480fcf2ed713f20b25R28

@noahfalk Is it necessary to include this file as Content? We are not doing that in any other library that uses LibraryBuild.xml.

[noahfalk]

@noahfalk Is it necessary to include this file as Content? We are not doing that in any other library that uses LibraryBuild.xml.

I assume it isn't necessary. I probably added the file via the VS UI and I am speculating it may have created the content item + I didn't expect it to cause trouble so I didn't remove it. Feel free to adjust or remove it as long as the linker directives are still observed.