Skip to content

Conversation

lewing
Copy link
Member

@lewing lewing commented Sep 18, 2024

@ghost ghost added the area-Build-mono label Sep 18, 2024
@lewing lewing requested a review from steveisok September 18, 2024 20:39
@lewing lewing added the area-Workloads Workloads like wasm-tools label Sep 18, 2024
@lewing
Copy link
Member Author

lewing commented Sep 18, 2024

There may be more changes needed to fix wbt here

@carlossanlop
Copy link
Contributor

The CI failures seem related.

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Sep 19, 2024
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures are gone. Tell-mode, adding servicing-approved.

Feel free to also wait for an area expert sign-off - @akoeplinger or @steveisok .

@lewing
Copy link
Member Author

lewing commented Sep 20, 2024

the remaining failures appear to be because dotnet/emsdk#940 needs to merge first

@lewing
Copy link
Member Author

lewing commented Sep 20, 2024

the remaining failures appear to be because dotnet/emsdk#940 needs to merge first

The flow is here, waiting for the build to complete.

@lewing
Copy link
Member Author

lewing commented Sep 20, 2024

/ba-g release branch and timeout

@lewing
Copy link
Member Author

lewing commented Sep 20, 2024

Fixing this is required to unblock runtime flow into the sdk at dotnet/sdk#43554

@lewing
Copy link
Member Author

lewing commented Sep 20, 2024

/ba-g failures are known

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Build-mono area-Workloads Workloads like wasm-tools Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants