-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Disable odbc tests on net9 interpreter #117245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable odbc tests on net9 interpreter #117245
Conversation
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables a set of ODBC integration tests on the Mono interpreter (net9) by marking them with an ActiveIssue
attribute.
- Adds
[ActiveIssue(..., PlatformDetection.IsMonoInterpreter)]
to individual test methods. - Targets tests across multiple files to skip them until issue #116482 is addressed.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
src/libraries/System.Data.Odbc/tests/SmokeTest.cs | Marked CreateInsertSelectTest with ActiveIssue |
src/libraries/System.Data.Odbc/tests/ReaderTests.cs | Added ActiveIssue to several reader-related test methods |
src/libraries/System.Data.Odbc/tests/DependencyCheckTest.cs | Marked dependency-check test with ActiveIssue |
src/libraries/System.Data.Odbc/tests/ConnectionTests.cs | Added ActiveIssue to connection test |
src/libraries/System.Data.Odbc/tests/CommandBuilderTests.cs | Marked command-builder tests with ActiveIssue |
@ericstj @akoeplinger This is just for green CI on .net9. What would be the process with this ? Does it need to go through normal tactics approval like normal fixes ? |
Test-only changes are tell-mode. |
@BrzVlad you're free to merge this. |
#116482