Skip to content

Conversation

BrzVlad
Copy link
Member

@BrzVlad BrzVlad commented Jul 2, 2025

@Copilot Copilot AI review requested due to automatic review settings July 2, 2025 15:18
Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables a set of ODBC integration tests on the Mono interpreter (net9) by marking them with an ActiveIssue attribute.

  • Adds [ActiveIssue(..., PlatformDetection.IsMonoInterpreter)] to individual test methods.
  • Targets tests across multiple files to skip them until issue #116482 is addressed.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/libraries/System.Data.Odbc/tests/SmokeTest.cs Marked CreateInsertSelectTest with ActiveIssue
src/libraries/System.Data.Odbc/tests/ReaderTests.cs Added ActiveIssue to several reader-related test methods
src/libraries/System.Data.Odbc/tests/DependencyCheckTest.cs Marked dependency-check test with ActiveIssue
src/libraries/System.Data.Odbc/tests/ConnectionTests.cs Added ActiveIssue to connection test
src/libraries/System.Data.Odbc/tests/CommandBuilderTests.cs Marked command-builder tests with ActiveIssue

@BrzVlad
Copy link
Member Author

BrzVlad commented Jul 2, 2025

@ericstj @akoeplinger This is just for green CI on .net9. What would be the process with this ? Does it need to go through normal tactics approval like normal fixes ?

@akoeplinger
Copy link
Member

Test-only changes are tell-mode.

@akoeplinger akoeplinger added the Servicing-approved Approved for servicing release label Jul 2, 2025
@ericstj
Copy link
Member

ericstj commented Jul 7, 2025

@BrzVlad you're free to merge this.

@BrzVlad BrzVlad merged commit f1308f0 into dotnet:release/9.0-staging Jul 8, 2025
26 of 29 checks passed
This was referenced Aug 5, 2025
This was referenced Aug 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants