Fix phantom text being read by Narrator #50752
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
FailureRestartTextlabel appears at the end of the Window, the ordering appears to impact how accessibility data is retrieved. The failure text ends up being assigned to the logo image, which results in Narrator announcing non-visible text. The announcement instructs users to uninstall and restart their machines, even though the user completed a successful install. This is confusing for users that rely on audible responses.The RCA is not complete, but initial investigations hint at ordering impacts what
IAccessiblemay be returningBelow is a screenshot from AI and the failure page text being assigned to the logo on the Success page
Before
After
Layout fixes
The PR also contains corrections for two labels (including the failure text) that incorrectly set the height to 34 instead of 32.