-
Notifications
You must be signed in to change notification settings - Fork 392
Open
Labels
Priority:2Work that is important, but not critical for the releaseWork that is important, but not critical for the releasearea: apiRelated to public API changes/bugsRelated to public API changes/bugsarea: refactoringThe technical improvement/refactoringThe technical improvement/refactoringgood first issueeasy issue, good for first-time contribution to the repoeasy issue, good for first-time contribution to the repotriagedThe issue was evaluated by the triage team, placed on correct area, next action defined.The issue was evaluated by the triage team, placed on correct area, next action defined.
Milestone
Description
This is a refactoring task that can be done after new parser is implemented.
Applicable to two creation results:
MissingMandatoryParam
, InvalidParamValues
.
Both of these cases are caused by invalid parameters passed to TemplateCreator
on template creation.
The error message returned by TemplateCreator
in those cases is poor:
- for
MissingMandatoryParam
it is a comma-separated list of missing parameters - similar to
InvalidParamValues
Due to this, TemplateInvoker
in CLI has weird logic of parsing those messages, as it needs to show errors about options, and not parameter names.
Consider improving ITemplateCreationResult
for these statuses. As example, it may contain dictionary with parameters and localized error message, then TemplateInvoker
can use it to show error message vs template options.
Metadata
Metadata
Assignees
Labels
Priority:2Work that is important, but not critical for the releaseWork that is important, but not critical for the releasearea: apiRelated to public API changes/bugsRelated to public API changes/bugsarea: refactoringThe technical improvement/refactoringThe technical improvement/refactoringgood first issueeasy issue, good for first-time contribution to the repoeasy issue, good for first-time contribution to the repotriagedThe issue was evaluated by the triage team, placed on correct area, next action defined.The issue was evaluated by the triage team, placed on correct area, next action defined.