No longer download OmniSharp from GitHub releases #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| "runtime": "", | ||
| "runtimeArgs": [], | ||
| "program": "./out/coreclr-debug/proxy.js", | ||
| "program": "./coreclr-debug/debugAdapters/OpenDebugAD7", |
There was a problem hiding this comment.
You don't want this change
DustinCampbell
force-pushed
the
fix-omnisharp-download
branch
from
00282f5 to
4b48c62
Compare
|
Fixed those bits Gregg. |
|
|
||
| const repo = new Github({ repo: OmnisharpRepo, token: ApiToken }); | ||
| const assetName = getOmnisharpAssetName(); | ||
| const urlString = `${BaseDownloadUrl}/${assetName}`; |
There was a problem hiding this comment.
I am not sure if we really want to fix this since it is already published to blob storage, but should there be a version number as part of this URL?
There was a problem hiding this comment.
Almost certainly, but I agree that we could do that next time.
|
Otherwise LGTM |
|
Can't comment too intelligently on TypeScript, but the logic looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the code that discovers and downloads OmniSharp from the GitHub and switches over to Azure blog storage.
cc @MattGertz, @gregg-miskelly, @caslan, @chuckries, @jaredpar