Skip to content

Conversation

s5no5t
Copy link
Contributor

@s5no5t s5no5t commented May 19, 2016

Add libraries http-proxy-agent and https-proxy-agent
just like vscode itself does and then use that to
request omnisharp binaries.
Most code is taken from vscode and adapted.

Fixes #349

Add libraries http-proxy-agent and https-proxy-agent
just like vscode itself does and then use that to
request omnisharp binaries.
Most code is taken from vscode and adapted.
@dnfclas
Copy link

dnfclas commented May 19, 2016

Hi @jugglingthebits, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

"runtimeArgs": [],
"program": "./out/coreclr-debug/proxy.js",
"program": "./coreclr-debug/debugAdapters/OpenDebugAD7.exe",
"aiKey": "AIF-d9b70cd4-b9f9-4d70-929b-a071c400b217",
"configurationAttributes": {
"launch": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to undo these changes in the debuggers section. This change occurs because the extension rewrites this portion of its manifest during activation. F5'ing the extension in dev scenarios causes this rewrite to occur, but the changes cannot be checked in.

@s5no5t
Copy link
Contributor Author

s5no5t commented May 19, 2016

I just noticed that my change breaks the gulpfile: For the "omnisharp:fetch" task, the plugin itself is loaded and through my path it takes a dependency on the vscode module, which isn't there when gulp runs:
const omnisharpDownload = require('./out/omnisharpDownload');

Is that task used somewhere? I would thing a dependency on compiled code shouldn't be in the gulpfile.

@DustinCampbell
Copy link
Member

Thanks for your contribution! If you can sign the CLA, I'll be happy to merge this in.

WRT the gulp task: Yeah, there was a desire to be able to specifically download the OmniSharp server as part of a gulp task so that we could include it in build on some occasions. For now, I think you can just comment that gulp task.

@@ -0,0 +1,46 @@
/*---------------------------------------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh... I wish we didn't have to copy and paste this from VS Code and could just leverage their that's already running. But, 👍

…nload tries to get proxy info from the user's config.
@dnfclas
Copy link

dnfclas commented May 23, 2016

@jugglingthebits, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@DustinCampbell
Copy link
Member

Thanks for signing the CLA! Merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants