-
Notifications
You must be signed in to change notification settings - Fork 724
Fix respecting a system or user configured proxy. #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add libraries http-proxy-agent and https-proxy-agent just like vscode itself does and then use that to request omnisharp binaries. Most code is taken from vscode and adapted.
Hi @jugglingthebits, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
"runtimeArgs": [], | ||
"program": "./out/coreclr-debug/proxy.js", | ||
"program": "./coreclr-debug/debugAdapters/OpenDebugAD7.exe", | ||
"aiKey": "AIF-d9b70cd4-b9f9-4d70-929b-a071c400b217", | ||
"configurationAttributes": { | ||
"launch": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to undo these changes in the debuggers section. This change occurs because the extension rewrites this portion of its manifest during activation. F5'ing the extension in dev scenarios causes this rewrite to occur, but the changes cannot be checked in.
I just noticed that my change breaks the gulpfile: For the "omnisharp:fetch" task, the plugin itself is loaded and through my path it takes a dependency on the vscode module, which isn't there when gulp runs: Is that task used somewhere? I would thing a dependency on compiled code shouldn't be in the gulpfile. |
Thanks for your contribution! If you can sign the CLA, I'll be happy to merge this in. WRT the gulp task: Yeah, there was a desire to be able to specifically download the OmniSharp server as part of a gulp task so that we could include it in build on some occasions. For now, I think you can just comment that gulp task. |
@@ -0,0 +1,46 @@ | |||
/*--------------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh... I wish we didn't have to copy and paste this from VS Code and could just leverage their that's already running. But, 👍
…nload tries to get proxy info from the user's config.
@jugglingthebits, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Thanks for signing the CLA! Merging... |
Add libraries http-proxy-agent and https-proxy-agent
just like vscode itself does and then use that to
request omnisharp binaries.
Most code is taken from vscode and adapted.
Fixes #349