update razor and fuse on #8047
Merged
update razor and fuse on #8047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 6, 2025 14:14
davidwengier
approved these changes
Mar 7, 2025
| @@ -23,17 +23,7 @@ export function resolveRazorLanguageServerOptions( | |||
| const usingOmniSharp = | |||
| !getCSharpDevKit() && vscodeApi.workspace.getConfiguration().get<boolean>('dotnet.server.useOmnisharp'); | |||
|
|
|||
| const hotReload = vscodeApi.workspace.getConfiguration('csharp.experimental.debug').get<boolean>('hotReload'); | |||
There was a problem hiding this comment.
If someone had set the fuse setting to false, would changing the default value of it cause their setting to change? If not, we may still need this??
There was a problem hiding this comment.
If someone had set the fuse setting to false
This doesn't override their setting. It just sets it to true if the value was unset (null default). If they set to false it should be equivalent today. We have telemetry for that so as we roll this out we can see if we need to change the name to override that (or just remove the option altogether)
There was a problem hiding this comment.
Oh you're right, sorry. I thought this made the hot reload setting override the FUSE setting, but it is only when unset. My b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View Complete Diff of Changes