Don't show duplicate toast if C# Dev Kit fails to activate #8135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plicate toasts if failure
dibarbet
force-pushed
the
dont_duplicate_toast
branch
from
1dbf02f to
dfb6d65
Compare
arunchndr
approved these changes
Apr 4, 2025
ryzngard
approved these changes
Apr 4, 2025
AArnott
approved these changes
Apr 4, 2025
| ): Promise<RoslynLanguageServer> { | ||
| const devKit = getCSharpDevKit(); | ||
| if (devKit) { | ||
| await devKit.activate(); |
There was a problem hiding this comment.
Allowing the exception to propagate will still produce an error toast in VS Code. But I don't know... maybe it'll be smaller?
There was a problem hiding this comment.
This shouldn't show a toast as best as I can tell - this is in a promise that isn't awaited in activation and not part of a callback from vscode . We write an error, but with this change I haven't managed to get a toast to display in any of the editors - I only get a devkit toast. I did manage to get a toast from C# with the previous version however.
|
/backport to prerelease |
|
Started backporting to prerelease: https://github.com/dotnet/vscode-csharp/actions/runs/14274365309 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
came up in another discussion - currently the vscode lsp client displays a toast if server startup fails. In server startup we're awaiting devkit activation - so if devkit activation fails we get two overlapping toasts.
This change moves us to await devkit activation outside of the server startup path. If devkit fails, we rely on them to display an error.