Skip to content

Update Roslyn 5.0.0-1.25256.5 (#8254) #8255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Update Roslyn 5.0.0-1.25256.5 (#8254) #8255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
* Fix syntax tree creation when modifying source generated documents (#78343) (PR: [#78343](https://github.com/dotnet/roslyn/pull/78343))

# 2.76.x
* Bump Roslyn to 5.0.0-1.25256.5 (PR: [#8254](https://github.com/dotnet/vscode-csharp/pull/8254))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dibarbet Is this just bad changelogging (there is a Roslyn bump above this in 2.77x to an older Roslyn version) or have we actually regressed Roslyn in 2.77.x by cherry picking an older commit that just has a new version number?

Happy to fix it in #8259 either way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So since the same bump did merge into prerelease, it is correct to list it under 2.76.x. I think removing the roslyn bump from 2.77.x makes sense unless you are also going to insert a new Roslyn in #8259.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, not planning on it. So to confirm, the two commits mentioned in the bump in 2.77 are in this build too? If so, I'll move those down in the changelog too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they would be. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we're merging changes into prerelease. There is going to be one more merge into prerelease as well, so fine to remove the roslyn bumps from the 2.77

* Do not parse URIs during LSP serialization/deserialization(PR: [#76691](https://github.com/dotnet/roslyn/pull/76691))
* Ensure hover markdown for supported platforms uses non-breaking spaces for indentation(PR: [#78405](https://github.com/dotnet/roslyn/pull/78405))
* Bump Razor to 10.0.0-preview.25252.1 (PR: [#8239](https://github.com/dotnet/vscode-csharp/pull/8239))
* If SupportDiagnostics is false then dynamic files don't report diagnostics... (PR: #11807)
* Client settings tweaks, and implement VS Code configuration monitoring (PR: #11800)
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"workspace"
],
"defaults": {
"roslyn": "5.0.0-1.25255.4",
"roslyn": "5.0.0-1.25256.5",
"omniSharp": "1.39.12",
"razor": "10.0.0-preview.25255.4",
"razorOmnisharp": "7.0.0-preview.23363.1",
Expand Down
Loading