Skip to content

Conversation

RikkiGibson
Copy link
Member

@RikkiGibson RikkiGibson commented Jun 26, 2025

Build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2737924&view=results

Changelog

  • Bump Roslyn to 5.0.0-1.25326.2 (PR: #8386)
    • Fix nullable oblivious quick info (PR: #79102)
    • Clear provider on disposal (PR: #79128)
    • Improve performance of fix all that only changes syntax (PR: #79108)
    • Convert to regular constructor for partial types (PR: #79092)
    • Fix roslyn test modifiers in semantic tokens (PR: #79070)
    • Fix restore for 'dotnet run app.cs' in IDE (PR: #78990)

@RikkiGibson RikkiGibson requested a review from a team as a code owner June 26, 2025 19:20
@RikkiGibson
Copy link
Member Author

The test failures look consistent. Unsure how to proceed with bumping the version. @jasonmalinowski @arunchndr for any suggestions you may have.

# Razor Test Integration RazorApp Razor Rename Basic Razor app / Local Variable
Error: expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 0
    at Object.<anonymous> (/Users/runner/work/1/s/test/razor/razorIntegrationTests/rename.integration.test.ts:51:32)

# [O#][singleCsproj][STDIO] DiagnosticProvider: single csproj at root of workspace / Test execution failure: could be caused by test hooks like 'afterAll'.
{"message":"","stack":"Error: write EPIPE\n at afterWriteDispatched (node:internal/stream_base_commons:159:15)\n at writeGeneric (node:internal/stream_base_commons:150:3)\n at Socket._writeGeneric (node:net:971:11)\n at Socket._write (node:net:983:8)\n at writeOrBuffer (node:internal/streams/writable:572:12)\n at _write (node:internal/streams/writable:501:10)\n at Socket.Writable.write (node:internal/streams/writable:510:10)\n at r._makeRequest (d:\\a\\_work\\1\\s\\dist\\extension.js:875:4083)\n at GA._makeRequest (d:\\a\\_work\\1\\s\\dist\\extension.js:874:72089)\n at GA.processPending (d:\\a\\_work\\1\\s\\dist\\extension.js:874:34029)\n at BU.drain (d:\\a\\_work\\1\\s\\dist\\extension.js:874:35136)\n at BU.enqueue (d:\\a\\_work\\1\\s\\dist\\extension.js:874:34648)\n at d:\\a\\_work\\1\\s\\dist\\extension.js:876:172\n at new Promise (<anonymous>)\n at r.makeRequest (d:\\a\\_work\\1\\s\\dist\\extension.js:876:78)\n at pH.makeRequest (d:\\a\\_work\\1\\s\\dist\\extension.js:958:2518)\n at ySe (d:\\a\\_work\\1\\s\\dist\\extension.js:873:18882)\n at pM.provideCodeActions (d:\\a\\_work\\1\\s\\dist\\extension.js:874:61138)\n at f1.provideCodeActions (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:147:131364)\n at file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:147:160465\n at Kt.s (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:147:155466)\n at Kt.$provideCodeActions (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:147:160453)\n at $5.S (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:29:116786)\n at $5.Q (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:29:116566)\n at $5.M (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:29:115617)\n at $5.L (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:29:114760)\n at ud.value (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:29:113557)\n at P.B (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:27:2373)\n at P.fire (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:27:2591)\n at po.fire (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:29:9458)\n at ud.value (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:361:3443)\n at P.B (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:27:2373)\n at P.fire (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:27:2591)\n at po.fire (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:29:9458)\n at MessagePortMain.<anonymous> (file:///d:/a/_work/1/s/.vscode-test/vscode-win32-x64-archive-1.101.2/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:361:1735)\n at MessagePortMain.emit (node:events:518:28)\n at MessagePor

@RikkiGibson
Copy link
Member Author

Tagging also @davidwengier in case you have any insight into the razor failures.

@@ -4,6 +4,33 @@
- Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876)

# 2.85.x
* Bump Roslyn to 5.0.0-1.25326.2 (PR: [#8386](https://github.com/dotnet/vscode-csharp/pull/8386))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider trimming the changes down to just things VS Code users might notice. eg, I'd remove things like code moves, infra, or VS features (like stack trace explorer).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I may have been a bit aggressive, but I got rid of any PRs which didn't look like they would affect vscode.

@davidwengier
Copy link
Member

These tests aren't the most stable, and the fact that the Razor tests passed in other OSes normally makes me think its just being flaky, but the failure seems consistent. I'll see if I can repro myself on Monday.

@davidwengier
Copy link
Member

The Razor leg passed on my machine, and then passed on retry this morning. Maybe there were infra issues a few days ago?

@RikkiGibson RikkiGibson enabled auto-merge (squash) June 30, 2025 02:43
@RikkiGibson RikkiGibson merged commit 85cd3f1 into main Jun 30, 2025
24 checks passed
@RikkiGibson RikkiGibson deleted the dev/rigibson/bump-roslyn branch June 30, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants