-
Notifications
You must be signed in to change notification settings - Fork 724
Bump Roslyn to 5.0.0-1.25326.2 #8386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The test failures look consistent. Unsure how to proceed with bumping the version. @jasonmalinowski @arunchndr for any suggestions you may have.
|
Tagging also @davidwengier in case you have any insight into the razor failures. |
@@ -4,6 +4,33 @@ | |||
- Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876) | |||
|
|||
# 2.85.x | |||
* Bump Roslyn to 5.0.0-1.25326.2 (PR: [#8386](https://github.com/dotnet/vscode-csharp/pull/8386)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider trimming the changes down to just things VS Code users might notice. eg, I'd remove things like code moves, infra, or VS features (like stack trace explorer).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I may have been a bit aggressive, but I got rid of any PRs which didn't look like they would affect vscode.
These tests aren't the most stable, and the fact that the Razor tests passed in other OSes normally makes me think its just being flaky, but the failure seems consistent. I'll see if I can repro myself on Monday. |
The Razor leg passed on my machine, and then passed on retry this morning. Maybe there were infra issues a few days ago? |
Build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2737924&view=results
Changelog