Update Razor cohosting to be 'on' by default. #8469
Conversation
phil-allen-msft
requested review from
davidwengier,
sayedihashimi,
ToddGrun and
chsienki
There was a problem hiding this comment.
Forgot one thing - can you also add a line in the changelog for this? Likely want to mention how people can turn it off if they have issues etc...
I also see the normal (previously non-cohosting) Razor tests are all failing - possibly they need to explicitly turn cohosting off now in the test config - https://github.com/dotnet/vscode-csharp/blob/main/test/razor/razorIntegrationTests/testAssets/RazorApp/.vscode/devkit_RazorApp.code-workspace
Thats a very good point I should have thought of. However, the fact that they're failing is surprising, as it implies that cohosting+devkit is having issues. |
|
Ran this branch up locally and manually verified, and everything works fine. Startup is pretty slow with devkit, so suspect that is what is going on. I think the failing tests are the only ones that don't retry. Also one of them is badly named :) Have pushed up the settings change suggested, since it makes sense anyway. |
|
Maybe we should be using https://jestjs.io/docs/jest-object#jestretrytimesnumretries-options |
|
Changelog updated. |
Update Razor cohosting to be 'on' by default.
Tested locally with a multi-project Blazor solution.