Do not allow client to modify whitespace for auto insert edits #8588
+82
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
changed the title
dibarbet
force-pushed
the
fix_on_auto_insert_whitespace
branch
from
ffb9364 to
c5ab09c
Compare
dibarbet
force-pushed
the
fix_on_auto_insert_whitespace
branch
from
c854d76 to
11bb070
Compare
JoeRobich
reviewed
Sep 9, 2025
| // and another to move the close brace to a new line below that). We still want to trigger on auto insert here, so remove | ||
| // duplicates before we check if the change matches a trigger character. | ||
| if (changeTrimmed.length > 1) { | ||
| changeTrimmed = [...new Set(changeTrimmed)].join(''); |
There was a problem hiding this comment.
changeTrimmed is a string. What is this intending to do?
There was a problem hiding this comment.
The idea is to remove duplicate newline characters from the string. Potentially this should instead just check if it the string is only new line characters, and remove duplicates then.
JoeRobich
reviewed
Sep 9, 2025
Comment on lines
+113
to
+114
| //const editor = vscode.window.activeTextEditor?.insertSnippet(); | ||
|
|
There was a problem hiding this comment.
Suggested change
| //const editor = vscode.window.activeTextEditor?.insertSnippet(); |
JoeRobich
reviewed
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell the client not to modify the whitespace we provided in auto insert snippets.
Requires dotnet/roslyn#80075