Skip to content

Commit 1307be2

Browse files
authored
Skip 3 localization tests (#13118)
Related #13117 Proposed changes Skip following 3 localization test cases System.Windows.Forms.Tests.KeysConverterTests.ConvertFrom_ShouldConvertKeys_Localization System.Windows.Forms.Tests.ToolStripMenuItemTests.ToolStripMenuItem_SetShortcutKeys_ReturnExpectedShortcutText System.Windows.Forms.Tests.KeysConverterTests.ConvertToString_ShouldConvertKeys_Localization
1 parent c22390c commit 1307be2

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/test/unit/System.Windows.Forms/System/Windows/Forms/KeysConverterTests.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ public void ConvertFrom_ShouldConvertKeys(string input, Keys keys)
2525
Assert.Equal(keys, result);
2626
}
2727

28-
[Theory]
28+
[ActiveIssue("https://github.com/dotnet/winforms/issues/13117")]
29+
[Theory(Skip = "Localization tests, see: https://github.com/dotnet/winforms/issues/13117")]
2930
[InlineData("fr-FR", "(aucun)", Keys.None)]
3031
[InlineData("nb-NO", "None", Keys.None)]
3132
[InlineData("de-DE", "Ende", Keys.End)]
@@ -71,7 +72,8 @@ public void ConvertToString_ShouldConvertKeys(Keys keys, string expectedResult)
7172
Assert.Equal(expectedResult, result);
7273
}
7374

74-
[Theory]
75+
[ActiveIssue("https://github.com/dotnet/winforms/issues/13117")]
76+
[Theory(Skip = "Localization tests, see: https://github.com/dotnet/winforms/issues/13117")]
7577
[InlineData("fr-FR", Keys.None, "(aucun)")]
7678
[InlineData("de-DE", Keys.End, "Ende")]
7779
public void ConvertToString_ShouldConvertKeys_Localization(string cultureName, Keys key, string expectedLocalizedKeyName)

src/test/unit/System.Windows.Forms/System/Windows/Forms/ToolStripMenuItemTests.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Licensed to the .NET Foundation under one or more agreements.
1+
// Licensed to the .NET Foundation under one or more agreements.
22
// The .NET Foundation licenses this file to you under the MIT license.
33

44
using System.ComponentModel;
@@ -143,7 +143,8 @@ public void ToolStripMenuItem_SetShortcutKeys_ThrowsInvalidEnumArgumentException
143143
Assert.Throws<InvalidEnumArgumentException>(() => item.ShortcutKeys = keys);
144144
}
145145

146-
[WinFormsTheory]
146+
[ActiveIssue("https://github.com/dotnet/winforms/issues/13117")]
147+
[WinFormsTheory(Skip = "Localization tests, see: https://github.com/dotnet/winforms/issues/13117")]
147148
[MemberData(nameof(CultureInfo_Shortcut_TestData))]
148149
public void ToolStripMenuItem_SetShortcutKeys_ReturnExpectedShortcutText(CultureInfo threadCulture, CultureInfo threadUICulture, string expectedShortcutText)
149150
{

0 commit comments

Comments
 (0)