Skip to content

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Mar 12, 2025

Related #13117

Proposed changes

  • Skip following 3 localization test cases
  1. System.Windows.Forms.Tests.KeysConverterTests.ConvertFrom_ShouldConvertKeys_Localization
  2. System.Windows.Forms.Tests.ToolStripMenuItemTests.ToolStripMenuItem_SetShortcutKeys_ReturnExpectedShortcutText
  3. System.Windows.Forms.Tests.KeysConverterTests.ConvertToString_ShouldConvertKeys_Localization
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner March 12, 2025 02:49
@LeafShi1 LeafShi1 requested a review from Tanya-Solyanik March 12, 2025 02:50
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.27545%. Comparing base (c22390c) to head (ed88623).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13118         +/-   ##
===================================================
- Coverage   61.28682%   61.27545%   -0.01137%     
===================================================
  Files           1541        1541                 
  Lines         158282      158282                 
  Branches       14743       14743                 
===================================================
- Hits           97006       96988         -18     
- Misses         60578       60596         +18     
  Partials         698         698                 
Flag Coverage Δ
Debug 61.27545% <ø> (-0.01137%) ⬇️
integration 10.73656% <ø> (ø)
production 39.13730% <ø> (-0.01869%) ⬇️
test 95.67280% <ø> (ø)
unit 36.55999% <ø> (-0.01869%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tanya-Solyanik Tanya-Solyanik merged commit 1307be2 into main Mar 12, 2025
8 checks passed
@Tanya-Solyanik Tanya-Solyanik deleted the Issue_13117_Skip_Three_Localization-tests branch March 12, 2025 04:04
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview3 milestone Mar 12, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants