Skip to content

Conversation

ricardobossan
Copy link
Member

@ricardobossan ricardobossan commented Feb 7, 2024

Related #10735

Proposed changes

  • Adds new control to the ErrorProvider form on the WinformsControlTests project;
  • Aims to test with scaling of multi-resolution icons on the ErrorProvider control.

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

Screenshot_2024-02-07_171323

After

Screenshot_2024-02-07_171900

Test methodology

  • Interactive test

Test environment(s)

  • 9.0.100-alpha.1.23618.3
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (4e56c2a) 73.22507% compared to head (ad5654f) 73.22003%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10847         +/-   ##
===================================================
- Coverage   73.22507%   73.22003%   -0.00505%     
===================================================
  Files           3071        3071                 
  Lines         633096      633141         +45     
  Branches       47388       47389          +1     
===================================================
+ Hits          463585      463586          +1     
- Misses        165970      166013         +43     
- Partials        3541        3542          +1     
Flag Coverage Δ
Debug 73.22003% <0.00000%> (-0.00505%) ⬇️
integration 18.30982% <ø> (-0.00387%) ⬇️
production 46.72507% <ø> (+0.00140%) ⬆️
test 94.99622% <0.00000%> (-0.01316%) ⬇️
unit 43.65109% <ø> (+0.00140%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonitra lonitra added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Feb 9, 2024
@Tanya-Solyanik Tanya-Solyanik merged commit 73685d8 into dotnet:main Feb 9, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview2 milestone Feb 9, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Feb 9, 2024
KlausLoeffelmann pushed a commit to KlausLoeffelmann/winforms that referenced this pull request Mar 5, 2024
…est (dotnet#10847)

Co-authored-by: Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants