Handle XAML data format #12975
Handle XAML data format #12975
Conversation
Handle XAML data format. For clarity, break helpers into three different text formats and add an HGLOBAL scope.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12975 +/- ##
===================================================
+ Coverage 75.98468% 75.98474% +0.00006%
===================================================
Files 3265 3266 +1
Lines 643356 643345 -11
Branches 47433 47429 -4
===================================================
- Hits 488852 488844 -8
- Misses 150943 150945 +2
+ Partials 3561 3556 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
| _buffer = new((byte*)_pointer, (int)length); | ||
| } | ||
|
|
||
| public HRESULT Status { get; private set; } = HRESULT.S_OK; |
There was a problem hiding this comment.
Consider naming this property HResult to indicate the type
There was a problem hiding this comment.
Generally speaking, properties should not be repeating the type. "Result" would be a good name normally, but in this case it is disconnected from the constructor method so I went with "Status". The other option was to have a static method that outs the HRESULT (which I still might do, as ComScope does). The struct itself has to be the return as otherwise writing the using is very awkward.
Handle XAML data format. For clarity, break helpers into three different text formats and add an HGLOBAL scope.
Handle XAML data format.
For clarity, break helpers into three different text formats and add an HGLOBAL scope.
Microsoft Reviewers: Open in CodeFlow