Skip to content

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Feb 24, 2025

Related #10773

Proposed changes

Add unit test file: ControlCodeDomSerializerTests.cs for public methods of the ControlCodeDomSerializer.cs.

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 72.97297% with 10 lines in your changes missing coverage. Please review.

Project coverage is 76.10686%. Comparing base (227fd3b) to head (5974482).
Report is 21 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13011         +/-   ##
===================================================
+ Coverage   76.04966%   76.10686%   +0.05719%     
===================================================
  Files           3269        3273          +4     
  Lines         643544      643737        +193     
  Branches       47429       47438          +9     
===================================================
+ Hits          489413      489928        +515     
+ Misses        150566      150237        -329     
- Partials        3565        3572          +7     
Flag Coverage Δ
Debug 76.10686% <72.97297%> (+0.05719%) ⬆️
integration 18.02634% <ø> (-0.01086%) ⬇️
production 50.13415% <ø> (+0.10273%) ⬆️
test 96.95174% <72.97297%> (+0.01448%) ⬆️
unit 47.57323% <ø> (+0.08600%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@LeafShi1
Copy link
Member

The file name should match the class name ControlCodeDomSerializerTests

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Feb 24, 2025
@LeafShi1 LeafShi1 removed the waiting-review This item is waiting on review by one or more members of team label Feb 24, 2025
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Feb 24, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

@ricardobossan ricardobossan added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Feb 24, 2025
@Zheng-Li01 Zheng-Li01 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Feb 25, 2025
@ricardobossan ricardobossan added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Feb 25, 2025
@Zheng-Li01 Zheng-Li01 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Feb 26, 2025
@Zheng-Li01 Zheng-Li01 requested review from a team and removed request for a team February 26, 2025 06:51
@LeafShi1
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 2dc1fbe into dotnet:main Feb 27, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview3 milestone Feb 27, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Feb 27, 2025
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_ControlCodeDomSerializer branch February 27, 2025 07:08
LeafShi1 pushed a commit to LeafShi1/winforms that referenced this pull request Mar 6, 2025
Related dotnet#10773

Proposed changes
Add unit test file: ControlCodeDomSerializerTests.cs for public methods of the ControlCodeDomSerializer.cs.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants