Skip to content

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Feb 25, 2025

Fixes #12988, #12989, #13000

Proposed changes

  • Use surface.CreateComponent<ToolStripButton> to initialize ToolStripItem and ToolStripMenuItem components in DemoConsole project
  • In the method OnListBoxItems_SelectedIndexChanged , use new object[] to correctly initialize an array of type object

Customer Impact

  • Operations in the Items Collection Editor can be successfully executed

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

  • The text is not correct in the default added Items Collection Editor dialog for MenuStrip control
  • After adding two items to the MenuStrip/ToolStrip project and clicking cancel, all items will disappear
  • Selecting two items at the same time in the MenuStrip/ToolStrip will result in an error

BeforeChanges

After

AfterChange

Test methodology

  • Manually

Test environment(s)

  • 10.0.0-preview.2.25119.7
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner February 25, 2025 08:10
@LeafShi1 LeafShi1 self-assigned this Feb 25, 2025
@LeafShi1 LeafShi1 requested a review from Copilot February 25, 2025 08:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.04657%. Comparing base (f280449) to head (0a501c8).
Report is 30 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13020         +/-   ##
===================================================
+ Coverage   76.01028%   76.04657%   +0.03629%     
===================================================
  Files           3267        3270          +3     
  Lines         643459      643553         +94     
  Branches       47432       47429          -3     
===================================================
+ Hits          489095      489400        +305     
+ Misses        150791      150586        -205     
+ Partials        3573        3567          -6     
Flag Coverage Δ
Debug 76.04657% <0.00000%> (+0.03629%) ⬆️
integration 18.01618% <0.00000%> (-0.01207%) ⬇️
production 50.02408% <0.00000%> (+0.06925%) ⬆️
test 96.93785% <ø> (+0.00101%) ⬆️
unit 47.46111% <0.00000%> (+0.04844%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Feb 26, 2025
@LeafShi1 LeafShi1 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Feb 26, 2025
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label Feb 26, 2025
@LeafShi1 LeafShi1 merged commit 8006401 into dotnet:main Feb 26, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview3 milestone Feb 26, 2025
LeafShi1 added a commit to LeafShi1/winforms that referenced this pull request Mar 6, 2025
…_DemoConsole

Fixed operation and display issues related to ToolStrip and ToolStripItemEditorForm in demoConsole
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the DemoConsole application, selecting two items at the same time in the MenuStrip/ToolStrip will result in an error
3 participants