-
Notifications
You must be signed in to change notification settings - Fork 1k
Fixed operation and display issues related to ToolStrip and ToolStripItemEditorForm in demoConsole #13020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed operation and display issues related to ToolStrip and ToolStripItemEditorForm in demoConsole #13020
Conversation
…ItemEditorForm in demoConsole
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All LGTM!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13020 +/- ##
===================================================
+ Coverage 76.01028% 76.04657% +0.03629%
===================================================
Files 3267 3270 +3
Lines 643459 643553 +94
Branches 47432 47429 -3
===================================================
+ Hits 489095 489400 +305
+ Misses 150791 150586 -205
+ Partials 3573 3567 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
src/System.Windows.Forms/tests/IntegrationTests/DesignSurface/DemoConsole/MainForm.cs
Outdated
Show resolved
Hide resolved
....Design/src/System/Windows/Forms/Design/ToolStripCollectionEditor.ToolStripItemEditorForm.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…_DemoConsole Fixed operation and display issues related to ToolStrip and ToolStripItemEditorForm in demoConsole
Fixes #12988, #12989, #13000
Proposed changes
surface.CreateComponent<ToolStripButton>
to initializeToolStripItem
andToolStripMenuItem
components in DemoConsole projectOnListBoxItems_SelectedIndexChanged
, usenew object[]
to correctly initialize an array of type objectCustomer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow