Consistently throw data on null data #13023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where we construct DataObject's directly or indirectly we should always throw for null data. This is to be more consistent with our APIs and also with WPF. Simplify test names in ClipboardTests for easier navigation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13023 +/- ##
====================================================
+ Coverage 76.05439% 96.93729% +20.88290%
====================================================
Files 3270 1221 -2049
Lines 643550 356971 -286579
Branches 47430 5529 -41901
====================================================
- Hits 489448 346038 -143410
+ Misses 150532 10092 -140440
+ Partials 3570 841 -2729
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tanya-Solyanik
approved these changes
Feb 25, 2025
Tanya-Solyanik
added
the
📖 documentation: breaking
|
Tested in the latest .NET 10 SDK build: 10.0.100-preview.3.25126.20 + dlls built from main branch of Winforms repo, now System.ArgumentNullException throws if setting null data by Clipboard.SetData() method: |
LeafShi1
pushed a commit
to LeafShi1/winforms
that referenced
this pull request
Mar 6, 2025
Where we construct DataObject's directly or indirectly we should always throw for null data. This is to be more consistent with our APIs and also with WPF. Simplify test names in ClipboardTests for easier navigation.
|
Verified with .NET 10.0.100-preview.3.25174.5 test pass build; the result is same as above test result. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where we construct DataObject's directly or indirectly we should always throw for null data. This is to be more consistent with our APIs and also with WPF.
Simplify test names in ClipboardTests for easier navigation.
Microsoft Reviewers: Open in CodeFlow