[release/9.0] Scale errorProvider Icon to DeviceDPI #13079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please read CONTRIBUTING.md before submitting a pull request --> Fixes dotnet#12939 ## Proposed changes - Scale errorProvider Icon to DeviceDPI <!-- We are in TELL-MODE the following section must be completed --> ## Customer Impact - The icon of errorProvider can be scaled well on HDPI screen ## Regression? - Yes ## Risk - Minimal <!-- end TELL-MODE --> ## Screenshots <!-- Remove this section if PR does not change UI --> ### Before The icon of errorProvider is not scaled well on HDPI screen with SystemAware and PerMoniterV2 modes  ### After The icon of errorProvider can be scaled well on HDPI screen  ## Test methodology <!-- How did you ensure quality? --> - Manually ## Test environment(s) <!-- Remove any that don't apply --> - .net 10.0.0-preview.2.25111.15 <!-- Mention language, UI scaling, or anything else that might be relevant --> ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/winforms/pull/12947)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/9.0 #13079 +/- ##
=====================================================
+ Coverage 74.83821% 74.84325% +0.00503%
=====================================================
Files 3022 3022
Lines 630460 630463 +3
Branches 46797 46801 +4
=====================================================
+ Hits 471825 471859 +34
+ Misses 155247 155218 -29
+ Partials 3388 3386 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
JeremyKuhne
approved these changes
Mar 5, 2025
JeremyKuhne
added
servicing-consider
LeafShi1
removed
the
🚫 * NO-MERGE *
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BackPort PR #12947 to 9.0
Fixes #12939
Proposed changes
Customer Impact
Regression?
Risk
Testing
Microsoft Reviewers: Open in CodeFlow