Skip to content

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 24, 2025

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

Microsoft Reviewers: Open in CodeFlow

@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner April 24, 2025 18:18
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

premun
premun previously requested changes Apr 24, 2025
Copy link
Member

@premun premun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViktorHofer so this now opens with the fixes in and we can review it tomorrow

@ViktorHofer
Copy link
Member

Reviewed the changes. Everything looks good. I guess we can merge it.

@ViktorHofer ViktorHofer enabled auto-merge (squash) April 24, 2025 18:37
@ViktorHofer ViktorHofer requested a review from premun April 24, 2025 18:37
@ViktorHofer ViktorHofer dismissed premun’s stale review April 24, 2025 18:38

We should be able to merge this one in already... No?

@ViktorHofer
Copy link
Member

The downgrades are intentional as the VMR doesn't yet have a build with the P5 branding.

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.58082%. Comparing base (3312c70) to head (238df9b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13370         +/-   ##
===================================================
+ Coverage   62.57269%   62.58082%   +0.00813%     
===================================================
  Files           1560        1560                 
  Lines         159763      159763                 
  Branches       14915       14915                 
===================================================
+ Hits           99968       99981         +13     
+ Misses         59018       59005         -13     
  Partials         777         777                 
Flag Coverage Δ
Debug 62.58082% <ø> (+0.00813%) ⬆️
integration 11.31959% <ø> (ø)
production 40.76032% <ø> (+0.01350%) ⬆️
test 95.69342% <ø> (ø)
unit 38.14355% <ø> (+0.00726%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ViktorHofer ViktorHofer merged commit fb328e6 into main Apr 24, 2025
11 of 13 checks passed
@ViktorHofer ViktorHofer deleted the darc-main-11bda034-4ca0-45c7-a518-b7766a5426c5 branch April 24, 2025 19:11
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants