Scaling ErrorProvider for high dpi #8486
Conversation
- Adding following windows message handling in the NativeWinodow to support components that are not derived from Control.
- WM.DPICHANGED_BEFOREPARENT
- WM.DPICHANGED_AFTERPARENT
- Replacing Windows Error Icon with Winforms specific and remove dependancy on Windows.
dreddy-work
changed the title
|
Test failure because you need to Update |
Thank you. It was not supposed to be removed. I was experimenting and forgot to add it back. |
Good to see unit test at work! |
src/System.Windows.Forms/src/System/Windows/Forms/ErrorProvider.ErrorWindow.cs
Show resolved
Hide resolved
| { | ||
| case User32.WM.DPICHANGED_BEFOREPARENT: | ||
| WmDpiChangedBeforeParent(ref m); | ||
| m.ResultInternal = (LRESULT)0; |
There was a problem hiding this comment.
Result is ignored by the system, I would delete all instances of us setting it.
There was a problem hiding this comment.
The m.ResultInternal is automatically set to (LRESULT)0 when the message is created, so there is no need for explicit setting. However, we have used this pattern in other places where we override or define WndProc.
Will have to revisit WndProc overrides in this code base to clean it up. Would consider a separate PR for that.
dreddy-work
added
the
📚 documentation
We regressed this issue here: #8486 by accidentally disposing Icons that may not be owned or created by us. In this scenario, It was default Icon that is getting disposed.
ghost
locked as resolved and limited conversation to collaborators
This change involves adding high DPI message handling to the
NativeWindowclass in order to support high DPI for components that are not derived fromControl. As a result, theErrorProvider,Timer,NotifyIcon, andToolTipcomponents will benefit from this change.Changes:
WM.DPICHANGED_BEFOREPARENTandWM.DPICHANGED_AFTERPARENTmessages inNativeWindowErrorProvider.Fixes #8264
Microsoft Reviewers: Open in CodeFlow