-
Notifications
You must be signed in to change notification settings - Fork 2
feat: upgrade API to backend v0.1.2-v0.2.1 fixes #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59f0a45
to
b5b354b
Compare
d0831ad
to
2978e18
Compare
- by allowing them to be grouped into buckets - and stacking bucket values on top of each other in the chart
- calculate the midpoint in a way to minimize the amount of liquidity value that is "behind enemy lines" of the midpoint
this value well represents value near the pair price and at extremes - eg. using a pair price of 100: - 1 token1 placed at price 10,000,000,000 is value of 100 - 1 token0 placed at price 0.00000000001 is value of 0.01 - the value of the bucket height represents the relative value of depositing that amount of reserves at this point in time (at this price, assuming our price is relatively accurate)
- and make the context properties more clearly differentiated
- this should help us not have to check for the pairID property whenever we want to use the type
- until the data is fixed - currently the endpoint only return positive index shares
- these trigger a dev console error - fix by explicitly returning null
- these methods were unreliable and would sometimes not connect to the endpoint as intended - possibly the resolving of the promise did not set the new value
2978e18
to
dbd05b7
Compare
dib542
pushed a commit
that referenced
this pull request
Jul 8, 2023
## [0.2.2](v0.2.1...v0.2.2) (2023-07-08) ### Features * upgrade API to backend v0.1.2-v0.2.1 fixes ([#382](#382)) ([bc02e13](bc02e13))
🎉 This PR is included in version 0.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds fixes related to the changes and features from the API upgrade from v0.1.2 to v0.2.1
useRpc
anduseLcdClient
hooks that were found to be unreliableuseQueries
hooks recomputing referentially unstable results on every rendertoken
andstake
prices bettertoken
andstake
would always be 0, which could look weird. Now they always resolve to 1USD, which is still weird, but visually much less weirder.