-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Measure current batch byte size and event count #18160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andsel
wants to merge
8
commits into
elastic:main
Choose a base branch
from
andsel:feature/current_metric_byte_size_event_count
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Measure current batch byte size and event count #18160
andsel
wants to merge
8
commits into
elastic:main
from
andsel:feature/current_metric_byte_size_event_count
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label. Could you fix it @andsel? 🙏
|
…keep the values correlated
…ocument count and batch bytes size)
…tric instance stored in the metric store.
…size and event_count
2e3ea64
to
00a395b
Compare
…not the last value
|
💚 Build Succeeded
History
cc @andsel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Implements current batch event count and byte size metrics.
What does this PR do?
Introduce a new gauge metric to collect list of values, used a a couple, the first element count of events in the batch and the second one is the estimated memory occupation of the batch.
This list is later grabbed in the API layer to populate the two
current
values forevent_count
andbatch_size
.Why is it important/What is the impact to the user?
Exposes the current batch size in terms of events and estimated memory consumption.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Start Logstash with
pipeline.batch.metrics.sampling_mode
set tofull
running an HTTP input pipeline, load it withwrk
and verify that the metric APIpipelines.main.batch.event_count.current
andpipelines.main.batch.byte_size.current
goes down to 0 whenwrk
is interrupted and gets a value other than 0 when the loadwrk
resumes.input_sample.txt
with some contentsend_file.lua
asconfig/logstash.yml
:wrk
, checking the metrics:Related issues