Skip to content

Conversation

erickzhao
Copy link
Member

BREAKING CHANGE: bumps required Node.js version to >=22.12.0. ESM-only.

@erickzhao erickzhao marked this pull request as ready for review September 3, 2025 20:10
@erickzhao erickzhao requested a review from a team as a code owner September 3, 2025 20:10
@erickzhao erickzhao requested a review from erikian September 5, 2025 20:43
Copy link

socket-security bot commented Sep 8, 2025

@@ -604,7 +604,7 @@ type CreateSignOptsResult = Mutable<
>;

export function createSignOpts(
properties: ComboOptions['osxSign'],
properties: Exclude<ComboOptions['osxSign'], undefined>,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After @erikian's latest round of reviews, a few things have changed in the implementation purely due to tightening up the types:

  • createSignOpts for macOS and Windows no longer takes in undefined.
  • Missing continueOnError option added to Windows.
  • We pass in identity: undefined instead of identity: null as a default for macOS since that's what the types expect for @electron/osx-sign.
  • More explicit control flow in createSignOpts.

These are all improvements that can be separated out of this PR as well if we think this is too scope-creepy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants