-
-
Notifications
You must be signed in to change notification settings - Fork 29
feat!: bump engines
requirement to Node 22
#1821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erickzhao
wants to merge
34
commits into
main
Choose a base branch
from
feat/node-22
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,044
−1,298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: bumps required Node.js version to >=22.12.0. ESM-only.
d38a870
to
861fb4b
Compare
MarshallOfSound
approved these changes
Sep 5, 2025
erikian
reviewed
Sep 5, 2025
Co-authored-by: Erik Moura <[email protected]>
erikian
approved these changes
Sep 8, 2025
Co-authored-by: Erik Moura <[email protected]>
Co-authored-by: Erik Moura <[email protected]>
erickzhao
commented
Sep 8, 2025
@@ -604,7 +604,7 @@ type CreateSignOptsResult = Mutable< | |||
>; | |||
|
|||
export function createSignOpts( | |||
properties: ComboOptions['osxSign'], | |||
properties: Exclude<ComboOptions['osxSign'], undefined>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After @erikian's latest round of reviews, a few things have changed in the implementation purely due to tightening up the types:
createSignOpts
for macOS and Windows no longer takes inundefined
.- Missing
continueOnError
option added to Windows. - We pass in
identity: undefined
instead ofidentity: null
as a default for macOS since that's what the types expect for@electron/osx-sign
. - More explicit control flow in
createSignOpts
.
These are all improvements that can be separated out of this PR as well if we think this is too scope-creepy.
dsanders11
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: bumps required Node.js version to >=22.12.0. ESM-only.