Add support for mix format plugins (#660) #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! It seems to work in a quick test, after playing with it some more I plan to merge it. |
DaliborHorinek
force-pushed
the
use-mix-formatter
branch
from
f66e009 to
c991f83
Compare
* Use formatter_for_file instead of formatter_opts_for_file which is deprecated now * Fallback to original Code.format_string!
DaliborHorinek
force-pushed
the
use-mix-formatter
branch
from
c991f83 to
0828610
Compare
|
I'll tried to make it backwards compatible with Elixir 1.12 and lower. This is how i tried, not sure if it's the best approach, but it seems to work. |
lukaszsamson
approved these changes
May 4, 2022
|
@lukaszsamson Thank you for you review, just a quick question. |
|
Thanks so much for tackling this @DaliborHorinek! This is such an exciting addition to support so much tooling. |
|
This is great news. Any hope of getting a release soon? |
|
@lukaszsamson Can I or anyone help to get a release for this feature? |
|
@marcandre FYI this was released as part of the v0.11.0 release today. |
|
Great, thanks @axelson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use mix formatter for formatting source file instead of Code.format_string! so it can support plugins in formatters.
Fix #660