Skip to content

Conversation

TeriyakiBomb
Copy link

As discussed here ember-learn/guides-source#1938 Map Box no longer allows access without a credit card, but TomTom does! (There's a cute joke in there somewhere) so this replaces Map Box.

Hopefully not missed anything.

@MinThaMie
Copy link
Contributor

Thanks for making this :)I've pinged @mansona personally to figure out why the build breaks

@MinThaMie
Copy link
Contributor

We'll first merge the gjs PR and then @tcjr will help us merge your fix into that new status!

@MinThaMie
Copy link
Contributor

@tcjr what's the best way to move this change now?

@tcjr
Copy link
Contributor

tcjr commented Sep 9, 2025

@tcjr what's the best way to move this change now?

I was just thinking that I'm not entirely sure how to go about this.

The bad news

I just looked at the merge conflicts and I don't think there's really any way to reconcile it in a traditional way. The nature of the changes in the base -- merging .js + .hbs => .gjs -- makes the diff a mess.

The good news

We are very fortunate that it's just this one chapter and the changes are completely self-contained. The component signature doesn't change, so subsequent mods around the Map component aren't affected. Yay encapsulation!

I think the best approach might be to create a new branch and manually copy the changes into the new .gjs files from either the .hbs or the .js. Unless somebody has a better suggestion, I can take a stab at it this morning and see if that works out ok.

Thoughts? @TeriyakiBomb

@TeriyakiBomb
Copy link
Author

It's just the one chapter as you say, so that's probably the easiest way to do it TBH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants