-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add a test that verifies @model
is stable between route transitions
#20959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Windvis
wants to merge
4
commits into
emberjs:main
Choose a base branch
from
Windvis:fix/unstable-@model-value-when-transitioning-between-routes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add a test that verifies @model
is stable between route transitions
#20959
Windvis
wants to merge
4
commits into
emberjs:main
from
Windvis:fix/unstable-@model-value-when-transitioning-between-routes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test doesn't actually reproduce the problem since a Glimmer component seems needed for that.
Estimated Asset SizesDiff Details
|
c96149a
to
e5ba618
Compare
90cddad
to
2622225
Compare
We now import the `@glimmer/component` package in test files which requires it to be built before Vite runs.
do you happen to know if this ever worked? |
I don't think so, no. As far as I know it has been an issue since It's just a tricky to reproduce issue so it seemed that it was "solved" at some point in time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a failing test for the issue mentioned in #18987 based on the StackBlitz reproduction and supersedes #19257.
I needed to do some changes to the Vite and CI setup to make the
@glimmer/component
imports working in the test files. Not sure if what I did is the best solution but it works for the reproduction at least.