[WIP] Deprecate Ember Utils #20968
Draft
[WIP] Deprecate Ember Utils #20968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Estimated Asset SizesDiff --- main/out.txt 2025-09-04 03:19:38.000000000 +0000
+++ pr/./pr-17465067592/out.txt 2025-09-04 13:15:14.000000000 +0000
@@ -1,46 +1,46 @@
╔═══════╤═══════════╤═══════════╗
║ │ Min │ Gzip ║
╟───────┼───────────┼───────────╢
-║ Total │ 418.65 KB │ 232.22 KB ║
+║ Total │ 417.27 KB │ 231.53 KB ║
╚═══════╧═══════════╧═══════════╝
-╔══════════════════════╤══════════╤═══════════╗
-║ @ember/* │ Min │ Gzip ║
-╟──────────────────────┼──────────┼───────────╢
-║ Total │ 239.4 KB │ 147.23 KB ║
-╟──────────────────────┼──────────┼───────────╢
-║ -internals │ 35.46 KB │ 25.49 KB ║
-║ application │ 12.83 KB │ 7.7 KB ║
-║ array │ 12.66 KB │ 7.32 KB ║
-║ canary-features │ 304 B │ 419 B ║
-║ component │ 1.07 KB │ 1005 B ║
-║ controller │ 1.8 KB │ 1.36 KB ║
-║ debug │ 11.4 KB │ 7.92 KB ║
-║ deprecated-features │ 31 B │ 77 B ║
-║ destroyable │ 561 B │ 383 B ║
-║ enumerable │ 259 B │ 387 B ║
-║ helper │ 823 B │ 605 B ║
-║ instrumentation │ 2.43 KB │ 1.78 KB ║
-║ modifier │ 669 B │ 581 B ║
-║ object │ 33.78 KB │ 20.79 KB ║
-║ owner │ 159 B │ 178 B ║
-║ renderer │ 406 B │ 350 B ║
-║ routing │ 58.08 KB │ 33.43 KB ║
-║ runloop │ 2.2 KB │ 1.33 KB ║
-║ service │ 859 B │ 741 B ║
-║ template │ 430 B │ 364 B ║
-║ template-compilation │ 429 B │ 366 B ║
-║ template-compiler │ 57.91 KB │ 30.4 KB ║
-║ template-factory │ 94 B │ 160 B ║
-║ test │ 923 B │ 627 B ║
-║ utils │ 3.93 KB │ 3.5 KB ║
-║ version │ 55 B │ 131 B ║
-╚══════════════════════╧══════════╧═══════════╝
+╔══════════════════════╤═══════════╤═══════════╗
+║ @ember/* │ Min │ Gzip ║
+╟──────────────────────┼───────────┼───────────╢
+║ Total │ 238.02 KB │ 146.52 KB ║
+╟──────────────────────┼───────────┼───────────╢
+║ -internals │ 35.52 KB │ 25.53 KB ║
+║ application │ 12.83 KB │ 7.63 KB ║
+║ array │ 12.68 KB │ 7.23 KB ║
+║ canary-features │ 304 B │ 419 B ║
+║ component │ 1.07 KB │ 974 B ║
+║ controller │ 1.8 KB │ 1.39 KB ║
+║ debug │ 10.73 KB │ 7.65 KB ║
+║ deprecated-features │ 31 B │ 77 B ║
+║ destroyable │ 561 B │ 383 B ║
+║ enumerable │ 259 B │ 387 B ║
+║ helper │ 823 B │ 604 B ║
+║ instrumentation │ 2.43 KB │ 1.78 KB ║
+║ modifier │ 669 B │ 590 B ║
+║ object │ 33.74 KB │ 20.79 KB ║
+║ owner │ 159 B │ 178 B ║
+║ renderer │ 406 B │ 333 B ║
+║ routing │ 57.65 KB │ 33.25 KB ║
+║ runloop │ 2.2 KB │ 1.31 KB ║
+║ service │ 859 B │ 744 B ║
+║ template │ 430 B │ 376 B ║
+║ template-compilation │ 429 B │ 366 B ║
+║ template-compiler │ 57.91 KB │ 30.4 KB ║
+║ template-factory │ 94 B │ 160 B ║
+║ test │ 923 B │ 627 B ║
+║ utils │ 3.6 KB │ 3.38 KB ║
+║ version │ 55 B │ 131 B ║
+╚══════════════════════╧═══════════╧═══════════╝
╔═════════════════╤═══════════╤══════════╗
║ @glimmer/* │ Min │ Gzip ║
╟─────────────────┼───────────┼──────────╢
-║ Total │ 179.25 KB │ 84.99 KB ║
+║ Total │ 179.25 KB │ 85 KB ║
╟─────────────────┼───────────┼──────────╢
║ destroyable │ 2.7 KB │ 1.35 KB ║
║ encoder │ 596 B │ 653 B ║
@@ -53,7 +53,7 @@
║ program │ 7.1 KB │ 3.63 KB ║
║ reference │ 5.51 KB │ 3.18 KB ║
║ runtime │ 95.26 KB │ 42.69 KB ║
-║ tracking │ 989 B │ 961 B ║
+║ tracking │ 989 B │ 975 B ║
║ util │ 3.03 KB │ 2.29 KB ║
║ validator │ 15.64 KB │ 6.86 KB ║
║ vm │ 784 B │ 798 B ║Details
|
wagenet
force-pushed
the
deprecate-ember-utils
branch
from
507c60e to
07d7d0d
Compare
wagenet
force-pushed
the
deprecate-ember-utils
branch
from
07d7d0d to
1e9c36d
Compare
8 tasks
|
And the deprecation guide: ember-learn/deprecation-app#1417 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emberjs/rfcs#1056
I think we just need to settle on the deprecation id and exact versions. We may also want to add
@deprecatedto the JSDoc.